summaryrefslogtreecommitdiff
path: root/sound/soc/amd/ps/acp63.h
diff options
context:
space:
mode:
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>2023-02-16 19:23:40 +0300
committerMark Brown <broonie@kernel.org>2023-02-16 19:31:15 +0300
commit1f810d2b6b2fbdc5279644d8b2c140b1f7c9d43d (patch)
treeef1da81e54aa5c3b482ac48b9eb0a9491a803b0e /sound/soc/amd/ps/acp63.h
parent5afc7eefe41645259da84898fc55f6f46cb4de47 (diff)
downloadlinux-1f810d2b6b2fbdc5279644d8b2c140b1f7c9d43d.tar.xz
ASoC: SOF: Intel: hda-dai: fix possible stream_tag leak
The HDaudio stream allocation is done first, and in a second step the LOSIDV parameter is programmed for the multi-link used by a codec. This leads to a possible stream_tag leak, e.g. if a DisplayAudio link is not used. This would happen when a non-Intel graphics card is used and userspace unconditionally uses the Intel Display Audio PCMs without checking if they are connected to a receiver with jack controls. We should first check that there is a valid multi-link entry to configure before allocating a stream_tag. This change aligns the dma_assign and dma_cleanup phases. Complements: b0cd60f3e9f5 ("ALSA/ASoC: hda: clarify bus_get_link() and bus_link_get() helpers") Link: https://github.com/thesofproject/linux/issues/4151 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Reviewed-by: Rander Wang <rander.wang@intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Link: https://lore.kernel.org/r/20230216162340.19480-1-peter.ujfalusi@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/amd/ps/acp63.h')
0 files changed, 0 insertions, 0 deletions