diff options
| author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2022-05-21 00:17:05 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-06-06 14:35:08 +0300 |
| commit | 94f8f2068ed0e3a5e367029f64ed76e6e65d5eb3 (patch) | |
| tree | d86d008d3ac8411d6d4d490014cbdd268359212c /sound/soc/codecs/cs42l42.c | |
| parent | 0511e2ac4e848ceac14b3ac4b476f0e26b48ddb2 (diff) | |
| download | linux-94f8f2068ed0e3a5e367029f64ed76e6e65d5eb3.tar.xz | |
ASoC: cs42l42: remove redundant test
cppcheck warning:
sound/soc/codecs/cs42l42.c:1704:28: style: The statement 'if
(cs42l42->plug_state!=CS42L42_TS_TRANS)
cs42l42->plug_state=CS42L42_TS_TRANS' is logically equivalent to
'cs42l42->plug_state=CS42L42_TS_TRANS'. [duplicateConditionalAssign]
if (cs42l42->plug_state != CS42L42_TS_TRANS)
^
sound/soc/codecs/cs42l42.c:1705:25: note: Assignment
'cs42l42->plug_state=CS42L42_TS_TRANS'
cs42l42->plug_state = CS42L42_TS_TRANS;
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20220520211719.607543-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/cs42l42.c')
| -rw-r--r-- | sound/soc/codecs/cs42l42.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 4fade2388797..6ca74c0d46ea 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -1701,8 +1701,7 @@ static irqreturn_t cs42l42_irq_thread(int irq, void *data) break; default: - if (cs42l42->plug_state != CS42L42_TS_TRANS) - cs42l42->plug_state = CS42L42_TS_TRANS; + cs42l42->plug_state = CS42L42_TS_TRANS; } } |