diff options
author | Wei Yongjun <weiyongjun1@huawei.com> | 2020-01-17 05:41:49 +0300 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2020-01-17 18:31:16 +0300 |
commit | f9f5bbf5783cd63369d3e6c8cf27e2bd7c5ac2c3 (patch) | |
tree | 0e4c67f25af49bfe0984aeea05cb19c719673eab /sound/soc/codecs/rt715-sdw.c | |
parent | b03c29c1b13afa18ee88cce07bbe87298eb0d3a3 (diff) | |
download | linux-f9f5bbf5783cd63369d3e6c8cf27e2bd7c5ac2c3.tar.xz |
ASoC: rt715: fix return value check in rt715_sdw_probe()
In case of error, the function devm_regmap_init() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Fixes: d1ede0641b05 ("ASoC: rt715: add RT715 codec driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200117024149.75515-1-weiyongjun1@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/rt715-sdw.c')
-rw-r--r-- | sound/soc/codecs/rt715-sdw.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c index 18868e4ae6e8..6d892c44c522 100644 --- a/sound/soc/codecs/rt715-sdw.c +++ b/sound/soc/codecs/rt715-sdw.c @@ -535,8 +535,8 @@ static int rt715_sdw_probe(struct sdw_slave *slave, regmap = devm_regmap_init(&slave->dev, NULL, &slave->dev, &rt715_regmap); - if (!regmap) - return -EINVAL; + if (IS_ERR(regmap)) + return PTR_ERR(regmap); rt715_init(&slave->dev, sdw_regmap, regmap, slave); |