diff options
| author | Venkata Prasad Potturu <venkataprasad.potturu@amd.com> | 2023-12-19 14:24:09 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-12-19 17:02:45 +0300 |
| commit | 802134c8c2c8889f7cc504ab1ba6ada9816ca969 (patch) | |
| tree | bfbacbc66332154959c75bbd7b19a3bd59df8826 /sound/soc/sof/amd/acp-ipc.c | |
| parent | 8b69dba103650b8247a336945c5fedc64ab5ddea (diff) | |
| download | linux-802134c8c2c8889f7cc504ab1ba6ada9816ca969.tar.xz | |
ASoC: SOF: amd: Refactor spinlock_irq(&sdev->ipc_lock) sequence in irq_handler
Refactor spinlock_irq(&sdev->ipc_lock) sequence in irq_handler
to avoid race conditions for acquiring hw_semaphore.
Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
Link: https://msgid.link/r/20231219112416.3334928-1-venkataprasad.potturu@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sof/amd/acp-ipc.c')
| -rw-r--r-- | sound/soc/sof/amd/acp-ipc.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/sound/soc/sof/amd/acp-ipc.c b/sound/soc/sof/amd/acp-ipc.c index fcb54f545fea..2743f07a5e08 100644 --- a/sound/soc/sof/amd/acp-ipc.c +++ b/sound/soc/sof/amd/acp-ipc.c @@ -3,7 +3,7 @@ // This file is provided under a dual BSD/GPLv2 license. When using or // redistributing this file, you may do so under either license. // -// Copyright(c) 2021 Advanced Micro Devices, Inc. +// Copyright(c) 2021, 2023 Advanced Micro Devices, Inc. // // Authors: Balakishore Pati <Balakishore.pati@amd.com> // Ajit Kumar Pandey <AjitKumar.Pandey@amd.com> @@ -188,13 +188,11 @@ irqreturn_t acp_sof_ipc_irq_thread(int irq, void *context) dsp_ack = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_SCRATCH_REG_0 + dsp_ack_write); if (dsp_ack) { - spin_lock_irq(&sdev->ipc_lock); /* handle immediate reply from DSP core */ acp_dsp_ipc_get_reply(sdev); snd_sof_ipc_reply(sdev, 0); /* set the done bit */ acp_dsp_ipc_dsp_done(sdev); - spin_unlock_irq(&sdev->ipc_lock); ipc_irq = true; } |