diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-01-19 15:31:01 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-01-19 19:47:36 +0300 |
| commit | 4c907bcd9dcd233da6707059d777ab389dcbd964 (patch) | |
| tree | 46728b53188c7d1e8c64c058aaad02bc0a5e6fad /sound | |
| parent | f7a6021aaf02088870559f82fc13c58cda7fea1a (diff) | |
| download | linux-4c907bcd9dcd233da6707059d777ab389dcbd964.tar.xz | |
ASoC: max9759: fix underflow in speaker_gain_control_put()
Check for negative values of "priv->gain" to prevent an out of bounds
access. The concern is that these might come from the user via:
-> snd_ctl_elem_write_user()
-> snd_ctl_elem_write()
-> kctl->put()
Fixes: fa8d915172b8 ("ASoC: max9759: Add Amplifier Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220119123101.GA9509@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/max9759.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/soc/codecs/max9759.c b/sound/soc/codecs/max9759.c index d75fd61b9032..bc57d7687f16 100644 --- a/sound/soc/codecs/max9759.c +++ b/sound/soc/codecs/max9759.c @@ -64,7 +64,8 @@ static int speaker_gain_control_put(struct snd_kcontrol *kcontrol, struct snd_soc_component *c = snd_soc_kcontrol_component(kcontrol); struct max9759 *priv = snd_soc_component_get_drvdata(c); - if (ucontrol->value.integer.value[0] > 3) + if (ucontrol->value.integer.value[0] < 0 || + ucontrol->value.integer.value[0] > 3) return -EINVAL; priv->gain = ucontrol->value.integer.value[0]; |