summaryrefslogtreecommitdiff
path: root/sound
diff options
context:
space:
mode:
authorDaniil Dementev <d.dementev@ispras.ru>2022-06-10 19:57:32 +0300
committerTakashi Iwai <tiwai@suse.de>2022-06-13 08:40:08 +0300
commit3ddbe35d9a2ebd4924d458e0246b4ba6c13bb456 (patch)
treeda607f141fcd72640a7dbaf19ec6345f7599a13a /sound
parentb2e6b3d9bbb0a59ba7c710cc06e44cc548301f5f (diff)
downloadlinux-3ddbe35d9a2ebd4924d458e0246b4ba6c13bb456.tar.xz
ALSA: usb-audio: US16x08: Move overflow check before array access
Buffer overflow could occur in the loop "while", due to accessing an array element before checking the index. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Daniil Dementev <d.dementev@ispras.ru> Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Link: https://lore.kernel.org/r/20220610165732.2904-1-d.dementev@ispras.ru Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r--sound/usb/mixer_us16x08.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
index b7b6f3834ed5..6eb7d93b358d 100644
--- a/sound/usb/mixer_us16x08.c
+++ b/sound/usb/mixer_us16x08.c
@@ -637,10 +637,10 @@ static int snd_get_meter_comp_index(struct snd_us16x08_meter_store *store)
}
} else {
/* skip channels with no compressor active */
- while (!store->comp_store->val[
+ while (store->comp_index <= SND_US16X08_MAX_CHANNELS
+ && !store->comp_store->val[
COMP_STORE_IDX(SND_US16X08_ID_COMP_SWITCH)]
- [store->comp_index - 1]
- && store->comp_index <= SND_US16X08_MAX_CHANNELS) {
+ [store->comp_index - 1]) {
store->comp_index++;
}
ret = store->comp_index++;