summaryrefslogtreecommitdiff
path: root/tools/gpio
diff options
context:
space:
mode:
authorIvo Borisov Shopov <ivoshopov@gmail.com>2023-01-26 16:10:33 +0300
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2023-01-27 16:05:46 +0300
commit677d85e1a1ee69fa05ccea83847309484be3781c (patch)
tree562b269eed424d502cc1c51f1cac00a1f32ed97f /tools/gpio
parentb710ef411048cdbd0fb279b9529af2731fe97022 (diff)
downloadlinux-677d85e1a1ee69fa05ccea83847309484be3781c.tar.xz
tools: gpio: fix -c option of gpio-event-mon
Following line should listen for a rising edge and exit after the first one since '-c 1' is provided. # gpio-event-mon -n gpiochip1 -o 0 -r -c 1 It works with kernel 4.19 but it doesn't work with 5.10. In 5.10 the above command doesn't exit after the first rising edge it keep listening for an event forever. The '-c 1' is not taken into an account. The problem is in commit 62757c32d5db ("tools: gpio: add multi-line monitoring to gpio-event-mon"). Before this commit the iterator 'i' in monitor_device() is used for counting of the events (loops). In the case of the above command (-c 1) we should start from 0 and increment 'i' only ones and hit the 'break' statement and exit the process. But after the above commit counting doesn't start from 0, it start from 1 when we listen on one line. It is because 'i' is used from one more purpose, counting of lines (num_lines) and it isn't restore to 0 after following code for (i = 0; i < num_lines; i++) gpiotools_set_bit(&values.mask, i); Restore the initial value of the iterator to 0 in order to allow counting of loops to work for any cases. Fixes: 62757c32d5db ("tools: gpio: add multi-line monitoring to gpio-event-mon") Signed-off-by: Ivo Borisov Shopov <ivoshopov@gmail.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> [Bartosz: tweak the commit message] Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Diffstat (limited to 'tools/gpio')
-rw-r--r--tools/gpio/gpio-event-mon.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/gpio/gpio-event-mon.c b/tools/gpio/gpio-event-mon.c
index 6c122952c589..5dee2b98ab60 100644
--- a/tools/gpio/gpio-event-mon.c
+++ b/tools/gpio/gpio-event-mon.c
@@ -86,6 +86,7 @@ int monitor_device(const char *device_name,
gpiotools_test_bit(values.bits, i));
}
+ i = 0;
while (1) {
struct gpio_v2_line_event event;