summaryrefslogtreecommitdiff
path: root/tools/perf/builtin-top.c
diff options
context:
space:
mode:
authorIan Rogers <irogers@google.com>2024-03-01 08:36:42 +0300
committerNamhyung Kim <namhyung@kernel.org>2024-03-04 09:51:44 +0300
commitd436f90a64f3e6b47464acc7821ce2b8a515a2ae (patch)
tree7e9cf55f7ffe4d9e0ea2b8e152469b8bc6f69820 /tools/perf/builtin-top.c
parent45ac4960d7fead9041fbfa15177fdd20b6af10f7 (diff)
downloadlinux-d436f90a64f3e6b47464acc7821ce2b8a515a2ae.tar.xz
perf machine: Move machine's threads into its own abstraction
Move thread_rb_node into the machine.c file. This hides the implementation of threads from the rest of the code allowing for it to be refactored. Locking discipline is tightened up in this change. As the lock is now encapsulated in threads, the findnew function requires holding it (as it already did in machine). Rather than do conditionals with locks based on whether the thread should be created (which could potentially be error prone with a read lock match with a write unlock), have a separate threads__find that won't create the thread and only holds the read lock. This effectively duplicates the findnew logic, with the existing findnew logic only operating under a write lock assuming creation is necessary as a previous find failed. The creation may still fail with the write lock due to another thread. The duplication is removed in a later next patch that delegates the implementation to hashtable. Signed-off-by: Ian Rogers <irogers@google.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Yang Jihong <yangjihong1@huawei.com> Cc: Oliver Upton <oliver.upton@linux.dev> Signed-off-by: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/r/20240301053646.1449657-5-irogers@google.com
Diffstat (limited to 'tools/perf/builtin-top.c')
0 files changed, 0 insertions, 0 deletions