summaryrefslogtreecommitdiff
path: root/tools/testing/selftests/pstore
diff options
context:
space:
mode:
authorShuah Khan (Samsung OSG) <shuah@kernel.org>2018-06-13 01:46:03 +0300
committerShuah Khan (Samsung OSG) <shuah@kernel.org>2018-06-18 18:11:09 +0300
commit856e7c4b619af622d56b3b454f7bec32a170ac99 (patch)
tree5d46b546d0d718321e07fdad3151feb3a726ebff /tools/testing/selftests/pstore
parentce397d215ccd07b8ae3f71db689aedb85d56ab40 (diff)
downloadlinux-856e7c4b619af622d56b3b454f7bec32a170ac99.tar.xz
selftests: pstore: return Kselftest Skip code for skipped tests
When pstore_post_reboot test gets skipped because of unmet dependencies and/or unsupported configuration, it returns 0 which is treated as a pass by the Kselftest framework. This leads to false positive result even when the test could not be run. Change it to return kselftest skip code when a test gets skipped to clearly report that the test could not be run. Kselftest framework SKIP code is 4 and the framework prints appropriate messages to indicate that the test is skipped. Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Diffstat (limited to 'tools/testing/selftests/pstore')
-rwxr-xr-xtools/testing/selftests/pstore/pstore_post_reboot_tests5
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests
index 6ccb154cb4aa..22f8df1ad7d4 100755
--- a/tools/testing/selftests/pstore/pstore_post_reboot_tests
+++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests
@@ -7,13 +7,16 @@
#
# Released under the terms of the GPL v2.
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
. ./common_tests
if [ -e $REBOOT_FLAG ]; then
rm $REBOOT_FLAG
else
prlog "pstore_crash_test has not been executed yet. we skip further tests."
- exit 0
+ exit $ksft_skip
fi
prlog -n "Mounting pstore filesystem ... "