diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2023-04-18 09:11:43 +0300 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2023-05-08 19:10:07 +0300 |
| commit | ba0ad6ed89fd5dada3b7b65ef2b08e95d449d4ab (patch) | |
| tree | d2574eeb7e9d84fab81d17950c36c2bc1d89e4c9 /tools/workqueue | |
| parent | ac9a78681b921877518763ba0e89202254349d1b (diff) | |
| download | linux-ba0ad6ed89fd5dada3b7b65ef2b08e95d449d4ab.tar.xz | |
media: nxp: imx8-isi: fix buiding on 32-bit
The #if check is wrong, leading to a build failure:
drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_inbuf':
drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:33:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
33 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
This could just be an #ifdef, but it seems nicer to just remove the
check entirely. Apparently the only reason for the #ifdef is to avoid
another warning:
drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:55:24: error: right shift count >= width of type [-Werror=shift-count-overflow]
But this is best avoided by using the lower_32_bits()/upper_32_bits()
helpers.
Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/workqueue')
0 files changed, 0 insertions, 0 deletions