summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2022-06-29 21:19:10 +0300
committerJakub Kicinski <kuba@kernel.org>2022-06-30 21:34:10 +0300
commitff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 (patch)
tree257bdc6083b6cb0de9b9fb20c4cea6dc724fb60a /tools
parent9c5de246c1dbe785268fc2e83c88624b92e4ec93 (diff)
downloadlinux-ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5.tar.xz
net: tun: avoid disabling NAPI twice
Eric reports that syzbot made short work out of my speculative fix. Indeed when queue gets detached its tfile->tun remains, so we would try to stop NAPI twice with a detach(), close() sequence. Alternative fix would be to move tun_napi_disable() to tun_detach_all() and let the NAPI run after the queue has been detached. Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues") Reported-by: syzbot <syzkaller@googlegroups.com> Reported-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions