From fa60629380bbbf0952d2eb906da187b171f54529 Mon Sep 17 00:00:00 2001 From: Jan Kara Date: Tue, 13 Feb 2024 11:16:01 +0100 Subject: ext4: don't report EOPNOTSUPP errors from discard When ext4 is mounted without journal, with discard mount option, and on a device not supporting trim, we print error for each and every freed extent. This is not only useless but actively harmful. Instead ignore the EOPNOTSUPP error. Trim is only advisory anyway and when the filesystem has journal we silently ignore trim error as well. Signed-off-by: Jan Kara Reviewed-by: Zhang Yi Link: https://lore.kernel.org/r/20240213101601.17463-1-jack@suse.cz Signed-off-by: Theodore Ts'o --- fs/ext4/mballoc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index bd26f2a90751..85a91a61b761 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -6496,7 +6496,13 @@ do_more: if (test_opt(sb, DISCARD)) { err = ext4_issue_discard(sb, block_group, bit, count_clusters, NULL); - if (err && err != -EOPNOTSUPP) + /* + * Ignore EOPNOTSUPP error. This is consistent with + * what happens when using journal. + */ + if (err == -EOPNOTSUPP) + err = 0; + if (err) ext4_msg(sb, KERN_WARNING, "discard request in" " group:%u block:%d count:%lu failed" " with %d", block_group, bit, count, -- cgit v1.2.3