From b19511926cb50d59c57189739d03c21df325710f Mon Sep 17 00:00:00 2001 From: Jonathan Corbet Date: Mon, 4 Oct 2021 17:12:56 -0600 Subject: Revert "docs: checkpatch: add UNNECESSARY/UNSPECIFIED_INT and UNNECESSARY_ELSE" This reverts commit cbb817fc2effcbee0eb44303eefbc8171fc2b12f. Late-arriving nacks make it clear that I applied this one too soon. Link: https://lore.kernel.org/lkml/CAKXUXMzEFQd1JJhx4ZbBQiuSB7Fk3bd7dwJYmPOvEtMqZopxpg@mail.gmail.com/ Signed-off-by: Jonathan Corbet --- Documentation/dev-tools/checkpatch.rst | 47 ---------------------------------- 1 file changed, 47 deletions(-) (limited to 'Documentation/dev-tools/checkpatch.rst') diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst index 5cbc8463b1f0..b52452bc2963 100644 --- a/Documentation/dev-tools/checkpatch.rst +++ b/Documentation/dev-tools/checkpatch.rst @@ -999,13 +999,6 @@ Functions and Variables return bar; - **UNNECESSARY_INT** - int used after short, long and long long is unnecessary. So remove it. - - **UNSPECIFIED_INT** - Kernel style prefers "unsigned int " over "unsigned " and - "signed int " over "signed ". - Permissions ----------- @@ -1254,43 +1247,3 @@ Others **TYPO_SPELLING** Some words may have been misspelled. Consider reviewing them. - - **UNNECESSARY_ELSE** - Using an else statement just after a return or a break statement is - unnecassary. For example:: - - for (i = 0; i < 100; i++) { - int foo = bar(); - if (foo < 1) - break; - else - usleep(1); - } - - is generally better written as:: - - for (i = 0; i < 100; i++) { - int foo = bar(); - if (foo < 1) - break; - usleep(1); - } - - So remove the else statement. But suppose if a if-else statement each - with a single return statement, like:: - - if (foo) - return bar; - else - return baz; - - then by removing the else statement:: - - if (foo) - return bar; - return baz; - - their is no significant increase in the readability and one can argue - that the first form is more readable because of indentation, so for - such cases do not convert the existing code from first form to second - form or vice-versa. -- cgit v1.2.3