From 57cfb0aba290cbc99842672ca4486d32177e7b15 Mon Sep 17 00:00:00 2001 From: Thierry Reding Date: Tue, 19 Dec 2023 18:15:23 +0100 Subject: arm64: tegra: Use consistent SD/MMC aliases on Tegra234 Tegra234 boards use a mixture of aliases for the SD/MMC hardware blocks, which can lead to confusion. A common method was to use mmc3 as the alias for the eMMC because "SDMMC3" happens to be the name of the corresponding controller in the reference manual. This isn't a great choice because there is no hardware named SDMMC0, so the mmc0 alias would never get used with that nomenclature and in fact mmc1 and mmc2 wouldn't either in many configurations, thereby creating weird discontiguous enumeration. Instead of trying to match the aliases to the hardware block names, use mmc0 to denote the device's primary SD/MMC controller (typically eMMC) and mmc1 for the secondary SD/MMC controller (typically removable SD). In cases where eMMC is the only controller we can omit the mmc1 alias and if a device has no eMMC, the removable SD card can be aliased to mmc0 instead. Co-developed-by: Russell Xiao Signed-off-by: Thierry Reding --- arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi | 5 +++++ arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 1 - arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 4 ++++ arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dts | 1 - 4 files changed, 9 insertions(+), 2 deletions(-) (limited to 'arch/arm64/boot/dts/nvidia') diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi index db6ef711674a..90f5adeba0f5 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi @@ -3,6 +3,11 @@ / { compatible = "nvidia,p3701", "nvidia,tegra234"; + aliases { + mmc0 = "/bus@0/mmc@3460000"; + mmc1 = "/bus@0/mmc@3400000"; + }; + bus@0 { aconnect@2900000 { status = "okay"; diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts index ea13c4a7027c..23b32d20a7e5 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts @@ -12,7 +12,6 @@ compatible = "nvidia,p3737-0000+p3701-0000", "nvidia,p3701-0000", "nvidia,tegra234"; aliases { - mmc3 = "/bus@0/mmc@3460000"; serial0 = &tcu; serial1 = &uarta; }; diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi index 59c14ded5e9f..bf93a32c343b 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi @@ -5,6 +5,10 @@ / { compatible = "nvidia,p3767", "nvidia,tegra234"; + aliases { + mmc0 = "/bus@0/mmc@3400000"; + }; + bus@0 { i2c@3160000 { status = "okay"; diff --git a/arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dts b/arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dts index 9f3e9f30c3f7..292e28376eec 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dts +++ b/arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dts @@ -8,7 +8,6 @@ compatible = "nvidia,tegra234-vdk", "nvidia,tegra234"; aliases { - mmc3 = "/bus@0/mmc@3460000"; serial0 = &uarta; }; -- cgit v1.2.3