From c74038baa9bccac76344b7215a55be136c81dfc3 Mon Sep 17 00:00:00 2001 From: Michal Simek Date: Tue, 17 Mar 2020 18:25:58 +0530 Subject: irqchip/xilinx: Fill error code when irq domain registration fails There is no ret filled in case of irq_domain_add_linear() failure. Signed-off-by: Michal Simek Signed-off-by: Marc Zyngier Reviewed-by: Stefan Asserhall Link: https://lore.kernel.org/r/20200317125600.15913-3-mubin.usman.sayyed@xilinx.com --- drivers/irqchip/irq-xilinx-intc.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/irqchip') diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c index 34593fa34c68..1d3d273309bd 100644 --- a/drivers/irqchip/irq-xilinx-intc.c +++ b/drivers/irqchip/irq-xilinx-intc.c @@ -228,6 +228,7 @@ static int __init xilinx_intc_of_init(struct device_node *intc, &xintc_irq_domain_ops, irqc); if (!irqc->root_domain) { pr_err("irq-xilinx: Unable to create IRQ domain\n"); + ret = -EINVAL; goto error; } -- cgit v1.2.3