From 184ae0e32bc990bba203b60503df89c9f8865f13 Mon Sep 17 00:00:00 2001 From: ChiYuan Huang Date: Fri, 25 Mar 2022 09:26:16 +0800 Subject: regulator: rt4831: Add bypass mask to fix set_bypass API work To use set/get_bypass helper function, bypass mask need to be specified. Signed-off-by: ChiYuan Huang Link: https://lore.kernel.org/r/1648171577-9663-2-git-send-email-u0084500@gmail.com Signed-off-by: Mark Brown --- drivers/regulator/rt4831-regulator.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/regulator') diff --git a/drivers/regulator/rt4831-regulator.c b/drivers/regulator/rt4831-regulator.c index 676b0419e48f..8d24b5ff4e2c 100644 --- a/drivers/regulator/rt4831-regulator.c +++ b/drivers/regulator/rt4831-regulator.c @@ -106,6 +106,7 @@ static const struct regulator_desc rt4831_regulator_descs[] = { .vsel_reg = RT4831_REG_VLCM, .vsel_mask = RT4831_VOLT_MASK, .bypass_reg = RT4831_REG_DSVEN, + .bypass_mask = RT4831_DSVMODE_MASK, .bypass_val_on = DSV_MODE_BYPASS, .bypass_val_off = DSV_MODE_NORMAL, .owner = THIS_MODULE, -- cgit v1.2.3 From aefe5fc3000a24869edbf7bb657adf28372ec158 Mon Sep 17 00:00:00 2001 From: ChiYuan Huang Date: Fri, 25 Mar 2022 09:26:17 +0800 Subject: regulator: rt4831: Add active_discharge_on to fix discharge API To use set_discharge helper function, active_discharge_on need to be added. Signed-off-by: ChiYuan Huang Link: https://lore.kernel.org/r/1648171577-9663-3-git-send-email-u0084500@gmail.com Signed-off-by: Mark Brown --- drivers/regulator/rt4831-regulator.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'drivers/regulator') diff --git a/drivers/regulator/rt4831-regulator.c b/drivers/regulator/rt4831-regulator.c index 8d24b5ff4e2c..2016062cd7ef 100644 --- a/drivers/regulator/rt4831-regulator.c +++ b/drivers/regulator/rt4831-regulator.c @@ -127,6 +127,7 @@ static const struct regulator_desc rt4831_regulator_descs[] = { .enable_mask = RT4831_POSEN_MASK, .active_discharge_reg = RT4831_REG_DSVEN, .active_discharge_mask = RT4831_POSADEN_MASK, + .active_discharge_on = RT4831_POSADEN_MASK, .owner = THIS_MODULE, }, { @@ -145,6 +146,7 @@ static const struct regulator_desc rt4831_regulator_descs[] = { .enable_mask = RT4831_NEGEN_MASK, .active_discharge_reg = RT4831_REG_DSVEN, .active_discharge_mask = RT4831_NEGADEN_MASK, + .active_discharge_on = RT4831_NEGADEN_MASK, .owner = THIS_MODULE, } }; -- cgit v1.2.3