From 337684a1746f93ae107e05d90977b070bb7e39d8 Mon Sep 17 00:00:00 2001 From: Eryu Guan Date: Tue, 2 Aug 2016 19:58:28 +0800 Subject: fs: return EPERM on immutable inode In most cases, EPERM is returned on immutable inode, and there're only a few places returning EACCES. I noticed this when running LTP on overlayfs, setxattr03 failed due to unexpected EACCES on immutable inode. So converting all EACCES to EPERM on immutable inode. Acked-by: Dave Chinner Signed-off-by: Eryu Guan Signed-off-by: Al Viro Signed-off-by: Linus Torvalds --- fs/utimes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'fs/utimes.c') diff --git a/fs/utimes.c b/fs/utimes.c index 85c40f4f373d..794f5f5b1fb5 100644 --- a/fs/utimes.c +++ b/fs/utimes.c @@ -92,10 +92,11 @@ static int utimes_common(struct path *path, struct timespec *times) * then we need to check permissions, because * inode_change_ok() won't do it. */ - error = -EACCES; + error = -EPERM; if (IS_IMMUTABLE(inode)) goto mnt_drop_write_and_out; + error = -EACCES; if (!inode_owner_or_capable(inode)) { error = inode_permission(inode, MAY_WRITE); if (error) -- cgit v1.2.3