From 6b4bfa43ce29165fb0a2a8ef770d94c1d93e5ad8 Mon Sep 17 00:00:00 2001 From: Jiri Pirko Date: Fri, 10 Feb 2023 11:01:31 +0100 Subject: devlink: add forgotten devlink instance lock assertion to devl_param_driverinit_value_set() Driver calling devl_param_driverinit_value_set() has to hold devlink instance lock while doing that. Put an assertion there. Signed-off-by: Jiri Pirko Reviewed-by: Simon Horman Acked-by: Jakub Kicinski Reviewed-by: Jacob Keller Signed-off-by: David S. Miller --- net/devlink/leftover.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'net') diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c index d4c896f89905..3569706c49e1 100644 --- a/net/devlink/leftover.c +++ b/net/devlink/leftover.c @@ -9681,6 +9681,8 @@ void devl_param_driverinit_value_set(struct devlink *devlink, u32 param_id, { struct devlink_param_item *param_item; + devl_assert_locked(devlink); + param_item = devlink_param_find_by_id(&devlink->params, param_id); if (WARN_ON(!param_item)) return; -- cgit v1.2.3