path: root/certs
diff options
authorJeffrey Hugo <>2018-05-12 02:01:42 +0300
committerLinus Torvalds <>2018-05-12 03:28:45 +0300
commitae646f0b9ca135b87bc73ff606ef996c3029780a (patch)
treebd65d4fd7a2473b504d46857c969512f24049d5a /certs
parent4ba281d5bd9907355e6b79fb72049c9ed50cc670 (diff)
init: fix false positives in W+X checking
load_module() creates W+X mappings via __vmalloc_node_range() (from layout_and_allocate()->move_module()->module_alloc()) by using PAGE_KERNEL_EXEC. These mappings are later cleaned up via "call_rcu_sched(&freeinit->rcu, do_free_init)" from do_init_module(). This is a problem because call_rcu_sched() queues work, which can be run after debug_checkwx() is run, resulting in a race condition. If hit, the race results in a nasty splat about insecure W+X mappings, which results in a poor user experience as these are not the mappings that debug_checkwx() is intended to catch. This issue is observed on multiple arm64 platforms, and has been artificially triggered on an x86 platform. Address the race by flushing the queued work before running the arch-defined mark_rodata_ro() which then calls debug_checkwx(). Link: Fixes: e1a58320a38d ("x86/mm: Warn on W^X mappings") Signed-off-by: Jeffrey Hugo <> Reported-by: Timur Tabi <> Reported-by: Jan Glauber <> Acked-by: Kees Cook <> Acked-by: Ingo Molnar <> Acked-by: Will Deacon <> Acked-by: Laura Abbott <> Cc: Mark Rutland <> Cc: Ard Biesheuvel <> Cc: Catalin Marinas <> Cc: Stephen Smalley <> Cc: Thomas Gleixner <> Cc: Peter Zijlstra <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'certs')
0 files changed, 0 insertions, 0 deletions