summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWang Ming <machel@vivo.com>2023-07-26 15:04:41 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2023-08-04 12:09:25 +0300
commit355bf65080399b0c1aba34368331802ce1998aef (patch)
tree67c84c8e3dae6083a2a0fdaa24e46aec49d9730c
parent322d74752c28a71fbca3650b98c21c58d25414a8 (diff)
downloadlinux-355bf65080399b0c1aba34368331802ce1998aef.tar.xz
crypto: atmel - Use dev_err_probe instead of dev_err
It is possible that dma_request_chan will return EPROBE_DEFER, which means that dd->dev is not ready yet. In this case, dev_err(dd->dev), there will be no output. This patch fixes the bug. Signed-off-by: Wang Ming <machel@vivo.com> Reviewed-by: Ryan Wanner <Ryan.Wanner@microchip.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/crypto/atmel-sha.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index f2031f934be9..54fec72dfba2 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -2499,8 +2499,8 @@ static int atmel_sha_dma_init(struct atmel_sha_dev *dd)
{
dd->dma_lch_in.chan = dma_request_chan(dd->dev, "tx");
if (IS_ERR(dd->dma_lch_in.chan)) {
- dev_err(dd->dev, "DMA channel is not available\n");
- return PTR_ERR(dd->dma_lch_in.chan);
+ return dev_err_probe(dd->dev, PTR_ERR(dd->dma_lch_in.chan),
+ "DMA channel is not available\n");
}
dd->dma_lch_in.dma_conf.dst_addr = dd->phys_base +