diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-12-09 09:54:51 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-12-09 15:12:58 +0300 |
| commit | 3cea33b6f2d7782d1be17c71509986f33ee93541 (patch) | |
| tree | ad2bfd98455efaeb04580eda9cd65ad53c669c82 | |
| parent | 1bea2256aa96a2d7b1b576eb74e29d79edc9bea8 (diff) | |
| download | linux-3cea33b6f2d7782d1be17c71509986f33ee93541.tar.xz | |
ASoC: max98390: Fix error codes in max98390_dsm_init()
These error paths return success but they should return -EINVAL.
Fixes: 97ed3e509ee6 ("ASoC: max98390: Fix potential crash during param fw loading")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X9B0uz4svyNTqeMb@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/max98390.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index ff5cc9bbec29..bb736c44e68a 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -784,6 +784,7 @@ static int max98390_dsm_init(struct snd_soc_component *component) if (fw->size < MAX98390_DSM_PARAM_MIN_SIZE) { dev_err(component->dev, "param fw is invalid.\n"); + ret = -EINVAL; goto err_alloc; } dsm_param = (char *)fw->data; @@ -794,6 +795,7 @@ static int max98390_dsm_init(struct snd_soc_component *component) fw->size < param_size + MAX98390_DSM_PAYLOAD_OFFSET) { dev_err(component->dev, "param fw is invalid.\n"); + ret = -EINVAL; goto err_alloc; } regmap_write(max98390->regmap, MAX98390_R203A_AMP_EN, 0x80); |