summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2023-09-16 00:49:33 +0300
committerHans de Goede <hdegoede@redhat.com>2023-09-21 19:31:18 +0300
commit45ae16ec3a3d63375cd95317af66b844661e86c4 (patch)
treea9afe2ce5dcf98ee199d0465d0729aa5523a09d8
parent318d97849fc2cb45b2238fdb9eaa714b5d669df5 (diff)
downloadlinux-45ae16ec3a3d63375cd95317af66b844661e86c4.tar.xz
platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830F/L vs 1050F/L detection
gpio_crystalcove pin 10 is already in input mode and passing GPIOD_IN when requesting the GPIO changes its pull-up/-down settings causing the 830F/L to get misdetected as 1050F/L. Switch to using GPIOD_ASIS when requesting the GPIO to fix the misdetection. Fixes: 4014ae236b1d ("platform/x86: x86-android-tablets: Stop using gpiolib private APIs") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230915214933.62595-1-hdegoede@redhat.com
-rw-r--r--drivers/platform/x86/x86-android-tablets/lenovo.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/x86-android-tablets/lenovo.c b/drivers/platform/x86/x86-android-tablets/lenovo.c
index 5c803cdb5586..c1e68211283f 100644
--- a/drivers/platform/x86/x86-android-tablets/lenovo.c
+++ b/drivers/platform/x86/x86-android-tablets/lenovo.c
@@ -436,7 +436,7 @@ static int __init lenovo_yoga_tab2_830_1050_init_touchscreen(void)
/* Use PMIC GPIO 10 bootstrap pin to differentiate 830 vs 1050 */
ret = x86_android_tablet_get_gpiod("gpio_crystalcove", 10, "yoga_bootstrap",
- false, GPIOD_IN, &gpiod);
+ false, GPIOD_ASIS, &gpiod);
if (ret)
return ret;