summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXin Liu <liuxin350@huawei.com>2022-09-30 12:07:08 +0300
committerAndrii Nakryiko <andrii@kernel.org>2022-10-01 01:16:22 +0300
commit51e05a8cf8eb34da7473823b7f236a77adfef0b4 (patch)
tree8f7cb7c5b1a2f5a1017ae2e40e9bb2c54670d93b
parent2efcf695bfc0f078dd7d5d23d96a97db34c930d5 (diff)
downloadlinux-51e05a8cf8eb34da7473823b7f236a77adfef0b4.tar.xz
libbpf: Fix overrun in netlink attribute iteration
I accidentally found that a change in commit 1045b03e07d8 ("netlink: fix overrun in attribute iteration") was not synchronized to the function `nla_ok` in tools/lib/bpf/nlattr.c, I think it is necessary to modify, this patch will do it. Signed-off-by: Xin Liu <liuxin350@huawei.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/bpf/20220930090708.62394-1-liuxin350@huawei.com
-rw-r--r--tools/lib/bpf/nlattr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/lib/bpf/nlattr.c b/tools/lib/bpf/nlattr.c
index f57e77a6e40f..3900d052ed19 100644
--- a/tools/lib/bpf/nlattr.c
+++ b/tools/lib/bpf/nlattr.c
@@ -32,7 +32,7 @@ static struct nlattr *nla_next(const struct nlattr *nla, int *remaining)
static int nla_ok(const struct nlattr *nla, int remaining)
{
- return remaining >= sizeof(*nla) &&
+ return remaining >= (int)sizeof(*nla) &&
nla->nla_len >= sizeof(*nla) &&
nla->nla_len <= remaining;
}