summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJun Gu <jun.gu@easystack.cn>2024-04-23 10:37:51 +0300
committerJakub Kicinski <kuba@kernel.org>2024-04-25 03:07:17 +0300
commit66270920f90fadb8f29477eb2b83cfb821bac621 (patch)
tree0ce996d4b043c838636678b6edd56082a3a7df22
parent9dd15d5088e9b322893459e38e1d279a33fc096c (diff)
downloadlinux-66270920f90fadb8f29477eb2b83cfb821bac621.tar.xz
net: openvswitch: Release reference to netdev
dev_get_by_name will provide a reference on the netdev. So ensure that the reference of netdev is released after completed. Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name") Signed-off-by: Jun Gu <jun.gu@easystack.cn> Reviewed-by: Aaron Conole <aconole@redhat.com> Link: https://lore.kernel.org/r/20240423073751.52706-1-jun.gu@easystack.cn Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--net/openvswitch/vport-netdev.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index 618edc346c0f..91a11067e458 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -78,12 +78,16 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
int err;
vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
+ if (!vport->dev) {
+ err = -ENODEV;
+ goto error_free_vport;
+ }
/* Ensure that the device exists and that the provided
* name is not one of its aliases.
*/
- if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
+ if (strcmp(name, ovs_vport_name(vport))) {
err = -ENODEV;
- goto error_free_vport;
+ goto error_put;
}
netdev_tracker_alloc(vport->dev, &vport->dev_tracker, GFP_KERNEL);
if (vport->dev->flags & IFF_LOOPBACK ||