summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Murray <andrew.murray@arm.com>2019-08-29 23:28:37 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-09-03 23:01:17 +0300
commit89e89b05ef5b58ab33070cc5b59d74ca8cff86fe (patch)
treeed46af23d946bc13e8d38e9f22ae428de3af9bd2
parent08d2ddaa585091d555a31d6ed538c6cedba060eb (diff)
downloadlinux-89e89b05ef5b58ab33070cc5b59d74ca8cff86fe.tar.xz
coresight: etm4x: improve clarity of etm4_os_unlock comment
To improve clarity, let's update the comment for etm4_os_unlock to use the name of the register as per the ETM architecture specification. The existing comment is also misleading as it suggests any value written to TRCOSLAR unlocks the trace registers, however it must be '0' - let's also correct this. Signed-off-by: Andrew Murray <andrew.murray@arm.com> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Link: https://lore.kernel.org/r/20190829202842.580-13-mathieu.poirier@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/hwtracing/coresight/coresight-etm4x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
index 615bdbf7c9b7..a128b5063f46 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -48,7 +48,7 @@ static enum cpuhp_state hp_online;
static void etm4_os_unlock(struct etmv4_drvdata *drvdata)
{
- /* Writing any value to ETMOSLAR unlocks the trace registers */
+ /* Writing 0 to TRCOSLAR unlocks the trace registers */
writel_relaxed(0x0, drvdata->base + TRCOSLAR);
drvdata->os_unlock = true;
isb();