summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2013-08-09 04:11:27 +0400
committerTejun Heo <tj@kernel.org>2013-08-09 04:11:27 +0400
commit95109b627ba6a043c181fa5fa45d1c754dd44fbc (patch)
treec01adf53fc1ea85cfe23bbe4c7b6b59d203cf2d3
parentd99c8727e7bbc01b70e2c57e6127bfab26b868fd (diff)
downloadlinux-95109b627ba6a043c181fa5fa45d1c754dd44fbc.tar.xz
cgroup: unexport cgroup_css()
cgroup_css() no longer has any user left outside cgroup.c proper and we don't want subsystems to grow new usages of the function. cgroup core should always provide the css to use to the subsystems, which will make dynamic creation and destruction of css's across the lifetime of a cgroup much more manageable than exposing the cgroup directly to subsystems and let them dereference css's from it. Make cgroup_css() a static function in cgroup.c. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Li Zefan <lizefan@huawei.com>
-rw-r--r--include/linux/cgroup.h13
-rw-r--r--kernel/cgroup.c13
2 files changed, 13 insertions, 13 deletions
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index d9a970568be9..c40e508d54e9 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -678,19 +678,6 @@ struct cgroup_subsys_state *css_parent(struct cgroup_subsys_state *css)
}
/**
- * cgroup_css - obtain a cgroup's css for the specified subsystem
- * @cgrp: the cgroup of interest
- * @subsys_id: the subsystem of interest
- *
- * Return @cgrp's css (cgroup_subsys_state) associated with @subsys_id.
- */
-static inline struct cgroup_subsys_state *cgroup_css(struct cgroup *cgrp,
- int subsys_id)
-{
- return cgrp->subsys[subsys_id];
-}
-
-/**
* task_css_set_check - obtain a task's css_set with extra access conditions
* @task: the task to obtain css_set for
* @__c: extra condition expression to be passed to rcu_dereference_check()
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index e5bfb2a81dcb..c02a288a4e3d 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -222,6 +222,19 @@ static int cgroup_destroy_locked(struct cgroup *cgrp);
static int cgroup_addrm_files(struct cgroup *cgrp, struct cftype cfts[],
bool is_add);
+/**
+ * cgroup_css - obtain a cgroup's css for the specified subsystem
+ * @cgrp: the cgroup of interest
+ * @subsys_id: the subsystem of interest
+ *
+ * Return @cgrp's css (cgroup_subsys_state) associated with @subsys_id.
+ */
+static struct cgroup_subsys_state *cgroup_css(struct cgroup *cgrp,
+ int subsys_id)
+{
+ return cgrp->subsys[subsys_id];
+}
+
/* convenient tests for these bits */
static inline bool cgroup_is_dead(const struct cgroup *cgrp)
{