summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXiaochen Wang <wangxiaochen0@gmail.com>2011-03-06 17:04:15 +0300
committerGreg Kroah-Hartman <gregkh@suse.de>2011-03-08 00:46:38 +0300
commit9603ff50b5d56e6ee64b10116ff640320732f9c8 (patch)
tree0e64dc27957623c7993c8d3769e312837de1e71c
parent0875abf83df7d74bf9858c125e82835bd1ca349c (diff)
downloadlinux-9603ff50b5d56e6ee64b10116ff640320732f9c8.tar.xz
staging: rtl8192e use kmemdup and check its return value
use kmemdup instead of kmalloc and memcpy, and check its return value Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c
index 88a9cd1958a8..fc96676bb9ce 100644
--- a/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192e/ieee80211/ieee80211_softmac.c
@@ -1564,8 +1564,9 @@ static inline u16 auth_parse(struct sk_buff *skb, u8** challenge, int *chlen)
if(*(t++) == MFIE_TYPE_CHALLENGE){
*chlen = *(t++);
- *challenge = kmalloc(*chlen, GFP_ATOMIC);
- memcpy(*challenge, t, *chlen);
+ *challenge = kmemdup(t, *chlen, GFP_ATOMIC);
+ if (!*challenge)
+ return -ENOMEM;
}
}