diff options
author | Coly Li <colyli@suse.de> | 2019-11-13 11:03:18 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-11-14 01:42:50 +0300 |
commit | aaf8dbeab5865720c66db60ae8329309e81a0c9c (patch) | |
tree | fb9032e81fad5cfee8e32b243cb42cb9ca28f57a | |
parent | 2d8869518a525c9bce5f5268419df9dfbe3dfdeb (diff) | |
download | linux-aaf8dbeab5865720c66db60ae8329309e81a0c9c.tar.xz |
bcache: add more accurate error messages in read_super()
Previous code only returns "Not a bcache superblock" for both bcache
super block offset and magic error. This patch addss more accurate error
messages,
- for super block unmatched offset:
"Not a bcache superblock (bad offset)"
- for super block unmatched magic number:
"Not a bcache superblock (bad magic)"
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r-- | drivers/md/bcache/super.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 7beccede5360..623fdaf10c4c 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -92,10 +92,11 @@ static const char *read_super(struct cache_sb *sb, struct block_device *bdev, pr_debug("read sb version %llu, flags %llu, seq %llu, journal size %u", sb->version, sb->flags, sb->seq, sb->keys); - err = "Not a bcache superblock"; + err = "Not a bcache superblock (bad offset)"; if (sb->offset != SB_SECTOR) goto err; + err = "Not a bcache superblock (bad magic)"; if (memcmp(sb->magic, bcache_magic, 16)) goto err; |