diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-11-08 12:31:52 +0300 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2021-12-03 16:27:19 +0300 |
| commit | b4a0de29f083cf8a705e1f381076ceeed7010d50 (patch) | |
| tree | 8e4d42f641fd32c04b1fd468cdde263c384b8f60 | |
| parent | 5765f4eb425cbe436f74a4ec700d0237caa36969 (diff) | |
| download | linux-b4a0de29f083cf8a705e1f381076ceeed7010d50.tar.xz | |
mtd: sst25l: Warn about failure to unregister mtd device
mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow.
This matches how other drivers (e.g. nand/raw/nandsim.c) use
mtd_device_unregister().
By returning 0 in the spi remove callback a generic error message by the
spi framework (and nothing else) is suppressed.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211108093153.63792-4-u.kleine-koenig@pengutronix.de
| -rw-r--r-- | drivers/mtd/devices/sst25l.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mtd/devices/sst25l.c b/drivers/mtd/devices/sst25l.c index b81c3f0b85f9..7f124c1bfa40 100644 --- a/drivers/mtd/devices/sst25l.c +++ b/drivers/mtd/devices/sst25l.c @@ -402,7 +402,9 @@ static int sst25l_remove(struct spi_device *spi) { struct sst25l_flash *flash = spi_get_drvdata(spi); - return mtd_device_unregister(&flash->mtd); + WARN_ON(mtd_device_unregister(&flash->mtd)); + + return 0; } static struct spi_driver sst25l_driver = { |