summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeng Hao <flyingpeng@tencent.com>2022-10-07 19:33:35 +0300
committerDavid Sterba <dsterba@suse.com>2022-12-05 20:00:36 +0300
commitc1b078545e64da7a2b67b74b9d12813b5dd2a529 (patch)
tree354c975ac863ab235fcf3e27c318fdc85c27dca3
parente5e886bad9e9e87b767ade3884faec1cfdec9b43 (diff)
downloadlinux-c1b078545e64da7a2b67b74b9d12813b5dd2a529.tar.xz
btrfs: simplify cleanup after error in btrfs_create_tree
Since leaf is already NULL, and no other branch will go to fail_unlock, the fail_unlock label is useless and can be removed Signed-off-by: Peng Hao <flyingpeng@tencent.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r--fs/btrfs/disk-io.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index d99bf7c64611..3460eaa9e4aa 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -1197,7 +1197,7 @@ struct btrfs_root *btrfs_create_tree(struct btrfs_trans_handle *trans,
if (IS_ERR(leaf)) {
ret = PTR_ERR(leaf);
leaf = NULL;
- goto fail_unlock;
+ goto fail;
}
root->node = leaf;
@@ -1232,9 +1232,6 @@ struct btrfs_root *btrfs_create_tree(struct btrfs_trans_handle *trans,
return root;
-fail_unlock:
- if (leaf)
- btrfs_tree_unlock(leaf);
fail:
btrfs_put_root(root);