diff options
| author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2023-01-30 17:15:40 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2023-01-31 11:34:04 +0300 |
| commit | c7a806d9ce6757ff56078674916e53bd859f242d (patch) | |
| tree | 176283250d168bba585ec4a0022548214db49671 | |
| parent | 4f876bfdb731a320089c5a64f8fa15fbba14418c (diff) | |
| download | linux-c7a806d9ce6757ff56078674916e53bd859f242d.tar.xz | |
ALSA: firewire-motu: fix unreleased lock warning in hwdep device
Smatch static analysis tool detects that acquired lock is not released
in hwdep device when condition branch is passed due to no event. It is
unlikely to occur, while fulfilling is preferable for better coding.
Reported-by: Dan Carpenter <error27@gmail.com>
Fixes: 634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20230130141540.102854-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/firewire/motu/motu-hwdep.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/firewire/motu/motu-hwdep.c b/sound/firewire/motu/motu-hwdep.c index a900fc0e7644..88d1f4b56e4b 100644 --- a/sound/firewire/motu/motu-hwdep.c +++ b/sound/firewire/motu/motu-hwdep.c @@ -87,6 +87,10 @@ static long hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count, return -EFAULT; count = consumed; + } else { + spin_unlock_irq(&motu->lock); + + count = 0; } return count; |