diff options
| author | Daniel Thompson <daniel.thompson@linaro.org> | 2024-04-24 17:03:38 +0300 |
|---|---|---|
| committer | Daniel Thompson <daniel.thompson@linaro.org> | 2024-04-26 19:13:30 +0300 |
| commit | c9b51ddb66b1d96e4d364c088da0f1dfb004c574 (patch) | |
| tree | 71ad387050acccda44f2dff7419220694ec72c21 | |
| parent | 6244917f377bf64719551b58592a02a0336a7439 (diff) | |
| download | linux-c9b51ddb66b1d96e4d364c088da0f1dfb004c574.tar.xz | |
kdb: Use format-specifiers rather than memset() for padding in kdb_read()
Currently when the current line should be removed from the display
kdb_read() uses memset() to fill a temporary buffer with spaces.
The problem is not that this could be trivially implemented using a
format string rather than open coding it. The real problem is that
it is possible, on systems with a long kdb_prompt_str, to write past
the end of the tmpbuffer.
Happily, as mentioned above, this can be trivially implemented using a
format string. Make it so!
Cc: stable@vger.kernel.org
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20240424-kgdb_read_refactor-v3-5-f236dbe9828d@linaro.org
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
| -rw-r--r-- | kernel/debug/kdb/kdb_io.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index a73779529803..2aeaf9765b24 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -318,11 +318,9 @@ poll_again: break; case 14: /* Down */ case 16: /* Up */ - memset(tmpbuffer, ' ', - strlen(kdb_prompt_str) + (lastchar-buffer)); - *(tmpbuffer+strlen(kdb_prompt_str) + - (lastchar-buffer)) = '\0'; - kdb_printf("\r%s\r", tmpbuffer); + kdb_printf("\r%*c\r", + (int)(strlen(kdb_prompt_str) + (lastchar - buffer)), + ' '); *lastchar = (char)key; *(lastchar+1) = '\0'; return lastchar; |