summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArmin Wolf <W_Armin@gmx.de>2023-03-24 23:26:27 +0300
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2023-03-30 20:01:05 +0300
commite5b492c6bb900fcf9722e05f4a10924410e170c1 (patch)
tree83ef7fc1f47b921d0443a3890adc74fd80ffcc2f
parent28f7b85895fce996c0f34827a7623ef6a031e4f3 (diff)
downloadlinux-e5b492c6bb900fcf9722e05f4a10924410e170c1.tar.xz
ACPI: EC: Fix oops when removing custom query handlers
When removing custom query handlers, the handler might still be used inside the EC query workqueue, causing a kernel oops if the module holding the callback function was already unloaded. Fix this by flushing the EC query workqueue when removing custom query handlers. Tested on a Acer Travelmate 4002WLMi Signed-off-by: Armin Wolf <W_Armin@gmx.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r--drivers/acpi/ec.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 5ef72287d1be..928899ab9502 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1133,6 +1133,7 @@ static void acpi_ec_remove_query_handlers(struct acpi_ec *ec,
void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit)
{
acpi_ec_remove_query_handlers(ec, false, query_bit);
+ flush_workqueue(ec_query_wq);
}
EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler);