summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJaejoong Kim <climbbb.kim@gmail.com>2018-02-27 05:15:59 +0300
committerTakashi Iwai <tiwai@suse.de>2018-02-27 11:16:52 +0300
commitef21e1750158558d8369067e94d02d285011c37e (patch)
treefc8da2a5cce3b8e4a10333196c0c3b6348f7116e
parent248a380a3c2e7e3363f26c17b6923b430cf6463e (diff)
downloadlinux-ef21e1750158558d8369067e94d02d285011c37e.tar.xz
ALSA: Use scnprintf() instead of snprintf() for show
The show() method should use scnprintf() not snprintf() because snprintf() may returns a value that exceeds its second argument. Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/core/init.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/core/init.c b/sound/core/init.c
index 4fa5dd955740..79b4df1c1dc7 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -670,7 +670,7 @@ card_id_show_attr(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct snd_card *card = container_of(dev, struct snd_card, card_dev);
- return snprintf(buf, PAGE_SIZE, "%s\n", card->id);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", card->id);
}
static ssize_t
@@ -710,7 +710,7 @@ card_number_show_attr(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct snd_card *card = container_of(dev, struct snd_card, card_dev);
- return snprintf(buf, PAGE_SIZE, "%i\n", card->number);
+ return scnprintf(buf, PAGE_SIZE, "%i\n", card->number);
}
static DEVICE_ATTR(number, S_IRUGO, card_number_show_attr, NULL);