diff options
author | Krzysztof Kozlowski <krzk@kernel.org> | 2020-09-17 21:56:13 +0300 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2020-09-30 19:46:29 +0300 |
commit | b727db94e3ba451a6941b0f8d8714f9f260ab110 (patch) | |
tree | 09bd26c3decc880a1fd58bd47e5c5f612ee6de2f /Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml | |
parent | e8299c7313af857254bc4304bc37482e9b952481 (diff) | |
download | linux-b727db94e3ba451a6941b0f8d8714f9f260ab110.tar.xz |
dt-bindings: mfd: Correct interrupt flags in examples
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> # for BD70528
Acked-by: Tim Harvey <tharvey@gateworks.com> # for gateworks-gsc.yaml
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml')
-rw-r--r-- | Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml index 9b6eb50606e8..e541eb0d02ed 100644 --- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml +++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml @@ -147,6 +147,7 @@ required: examples: - | #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> i2c { #address-cells = <1>; #size-cells = <0>; @@ -155,7 +156,7 @@ examples: compatible = "gw,gsc"; reg = <0x20>; interrupt-parent = <&gpio1>; - interrupts = <4 GPIO_ACTIVE_LOW>; + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; interrupt-controller; #interrupt-cells = <1>; #address-cells = <1>; |