summaryrefslogtreecommitdiff
path: root/Documentation/networking
diff options
context:
space:
mode:
authorJason Xing <kernelxing@tencent.com>2024-03-25 15:36:14 +0300
committerPablo Neira Ayuso <pablo@netfilter.org>2024-05-06 17:29:21 +0300
commit8edc27fc4f220179189932cb5f537f2e90a32b87 (patch)
treeb007b705b15a205a8b39864d30eda64dad2f71f2 /Documentation/networking
parent40616789ec462df0e97ee1d5aa4e4fed4249cae0 (diff)
downloadlinux-8edc27fc4f220179189932cb5f537f2e90a32b87.tar.xz
netfilter: use NF_DROP instead of -NF_DROP
At the beginning in 2009 one patch [1] introduced collecting drop counter in nf_conntrack_in() by returning -NF_DROP. Later, another patch [2] changed the return value of tcp_packet() which now is renamed to nf_conntrack_tcp_packet() from -NF_DROP to NF_DROP. As we can see, that -NF_DROP should be corrected. Similarly, there are other two points where the -NF_DROP is used. Well, as NF_DROP is equal to 0, inverting NF_DROP makes no sense as patch [2] said many years ago. [1] commit 7d1e04598e5e ("netfilter: nf_conntrack: account packets drop by tcp_packet()") [2] commit ec8d540969da ("netfilter: conntrack: fix dropping packet after l4proto->packet()") Signed-off-by: Jason Xing <kernelxing@tencent.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'Documentation/networking')
0 files changed, 0 insertions, 0 deletions