summaryrefslogtreecommitdiff
path: root/Documentation
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2014-07-18 21:56:34 +0400
committerDavid Howells <dhowells@redhat.com>2014-07-23 00:46:12 +0400
commit4d8c0250b841159b128785f7a7efbaff40cc8501 (patch)
tree88860f5296ab855ba75588a0ec3e9fce73b7def3 /Documentation
parent7dfa0ca6a95de65b7a7760630cdbd7d30f204bfa (diff)
downloadlinux-4d8c0250b841159b128785f7a7efbaff40cc8501.tar.xz
KEYS: Call ->free_preparse() even after ->preparse() returns an error
Call the ->free_preparse() key type op even after ->preparse() returns an error as it does cleaning up type stuff. Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Steve Dickson <steved@redhat.com> Acked-by: Jeff Layton <jlayton@primarydata.com> Reviewed-by: Sage Weil <sage@redhat.com>
Diffstat (limited to 'Documentation')
-rw-r--r--Documentation/security/keys.txt4
1 files changed, 3 insertions, 1 deletions
diff --git a/Documentation/security/keys.txt b/Documentation/security/keys.txt
index 315cf96a41a2..8727c194ca16 100644
--- a/Documentation/security/keys.txt
+++ b/Documentation/security/keys.txt
@@ -1176,7 +1176,9 @@ The structure has a number of fields, some of which are mandatory:
This method is only required if the preparse() method is provided,
otherwise it is unused. It cleans up anything attached to the
description, type_data and payload fields of the key_preparsed_payload
- struct as filled in by the preparse() method.
+ struct as filled in by the preparse() method. It will always be called
+ after preparse() returns successfully, even if instantiate() or update()
+ succeed.
(*) int (*instantiate)(struct key *key, struct key_preparsed_payload *prep);