diff options
author | Paolo Abeni <pabeni@redhat.com> | 2022-06-28 04:02:40 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-06-29 06:45:42 +0300 |
commit | 6aeed9045071f2252ff4e98fc13d1e304f33e5b0 (patch) | |
tree | f62decedccf2bba4c7f4d7ee478cab0732fe761c /Makefile | |
parent | f745a3ebdfb9041d3a55e66eb345895cd8ecc90c (diff) | |
download | linux-6aeed9045071f2252ff4e98fc13d1e304f33e5b0.tar.xz |
mptcp: fix race on unaccepted mptcp sockets
When the listener socket owning the relevant request is closed,
it frees the unaccepted subflows and that causes later deletion
of the paired MPTCP sockets.
The mptcp socket's worker can run in the time interval between such delete
operations. When that happens, any access to msk->first will cause an UaF
access, as the subflow cleanup did not cleared such field in the mptcp
socket.
Address the issue explicitly traversing the listener socket accept
queue at close time and performing the needed cleanup on the pending
msk.
Note that the locking is a bit tricky, as we need to acquire the msk
socket lock, while still owning the subflow socket one.
Fixes: 86e39e04482b ("mptcp: keep track of local endpoint still available for each msk")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions