diff options
author | SeongJae Park <sj@kernel.org> | 2023-10-23 00:07:33 +0300 |
---|---|---|
committer | Andrew Morton <akpm@linux-foundation.org> | 2023-11-01 22:38:35 +0300 |
commit | 19467a950b49432a84bf6dbadbbb17bdf89418b7 (patch) | |
tree | 655f2f496eeab04ea2cd9ffef9ffd0dfc861bc0c /README | |
parent | 6479b29203dedb724f4f4e08e1cc0dcf432c333b (diff) | |
download | linux-19467a950b49432a84bf6dbadbbb17bdf89418b7.tar.xz |
mm/damon/sysfs: remove requested targets when online-commit inputs
damon_sysfs_set_targets(), which updates the targets of the context for
online commitment, do not remove targets that removed from the
corresponding sysfs files. As a result, more than intended targets of the
context can exist and hence consume memory and monitoring CPU resource
more than expected.
Fix it by removing all targets of the context and fill up again using the
user input. This could cause unnecessary memory dealloc and realloc
operations, but this is not a hot code path. Also, note that damon_target
is stateless, and hence no data is lost.
[sj@kernel.org: fix unnecessary monitoring results removal]
Link: https://lkml.kernel.org/r/20231028213353.45397-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20231022210735.46409-2-sj@kernel.org
Fixes: da87878010e5 ("mm/damon/sysfs: support online inputs update")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: <stable@vger.kernel.org> [5.19.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'README')
0 files changed, 0 insertions, 0 deletions