diff options
author | Jeff Mahoney <jeffm@suse.com> | 2016-11-05 20:26:35 +0300 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2016-11-30 15:45:19 +0300 |
commit | d2fbb2b589ece9060635b43c2b2333d0b0a0fbf2 (patch) | |
tree | 0c966e4f6fd1b7115944f3a44c9c4c75adcc1b0d /README | |
parent | c2951f32d36c28d96acf95f0d83116facbec48a2 (diff) | |
download | linux-d2fbb2b589ece9060635b43c2b2333d0b0a0fbf2.tar.xz |
btrfs: increment ctx->pos for every emitted or skipped dirent in readdir
If we process the last item in the leaf and hit an I/O error while
reading the next leaf, we return -EIO without having adjusted the
position. Since we have emitted dirents, getdents() will return
the byte count to the user instead of the error. Subsequent callers
will emit the last successful dirent again, and return -EIO again,
with the same result. Callers loop forever.
Instead, if we always increment ctx->pos after emitting or skipping
the dirent, we'll be sure that we won't hit the same one again. When
we go to process the next leaf, we won't have emitted any dirents
and the -EIO will be returned to the user properly. We also don't
need to track if we've emitted a dirent already or if we've changed
the position yet.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'README')
0 files changed, 0 insertions, 0 deletions