summaryrefslogtreecommitdiff
path: root/arch/powerpc/sysdev/qe_lib
diff options
context:
space:
mode:
authorMichael Barkowski <michaelbarkowski@ruggedcom.com>2009-08-19 01:20:44 +0400
committerKumar Gala <galak@kernel.crashing.org>2009-08-26 06:08:45 +0400
commit1dcd8ffc81e80a170625883f63f6a5db3cd0428d (patch)
tree8e8f1a34d271a43408745e5eacf868307e85859b /arch/powerpc/sysdev/qe_lib
parent9b9d401b8d11796f4c4bcbcabecfec9f5d85ea25 (diff)
downloadlinux-1dcd8ffc81e80a170625883f63f6a5db3cd0428d.tar.xz
powerpc/qe_lib: Set gpio data before changing the direction to output
This avoids having a short glitch if the desired initial value is not the same as what was previously in the data register. Signed-off-by: Michael Barkowski <michaelbarkowski@ruggedcom.com> Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/sysdev/qe_lib')
-rw-r--r--arch/powerpc/sysdev/qe_lib/gpio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/powerpc/sysdev/qe_lib/gpio.c b/arch/powerpc/sysdev/qe_lib/gpio.c
index 3485288dce31..8e7a7767dd5c 100644
--- a/arch/powerpc/sysdev/qe_lib/gpio.c
+++ b/arch/powerpc/sysdev/qe_lib/gpio.c
@@ -105,14 +105,14 @@ static int qe_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
struct qe_gpio_chip *qe_gc = to_qe_gpio_chip(mm_gc);
unsigned long flags;
+ qe_gpio_set(gc, gpio, val);
+
spin_lock_irqsave(&qe_gc->lock, flags);
__par_io_config_pin(mm_gc->regs, gpio, QE_PIO_DIR_OUT, 0, 0, 0);
spin_unlock_irqrestore(&qe_gc->lock, flags);
- qe_gpio_set(gc, gpio, val);
-
return 0;
}