diff options
| author | Xiongfeng Wang <wangxiongfeng2@huawei.com> | 2022-11-18 09:31:36 +0300 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2022-11-24 13:09:25 +0300 |
| commit | 8ebd16c11c346751b3944d708e6c181ed4746c39 (patch) | |
| tree | 740e163a68c907ea7cf91b7b4ac9ec7ab89031d3 /arch/x86/events/intel | |
| parent | 1ff9dd6e7071a561f803135c1d684b13c7a7d01d (diff) | |
| download | linux-8ebd16c11c346751b3944d708e6c181ed4746c39.tar.xz | |
perf/x86/intel/uncore: Fix reference count leak in snr_uncore_mmio_map()
pci_get_device() will increase the reference count for the returned
pci_dev, so snr_uncore_get_mc_dev() will return a pci_dev with its
reference count increased. We need to call pci_dev_put() to decrease the
reference count. Let's add the missing pci_dev_put().
Fixes: ee49532b38dd ("perf/x86/intel/uncore: Add IMC uncore support for Snow Ridge")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-4-wangxiongfeng2@huawei.com
Diffstat (limited to 'arch/x86/events/intel')
| -rw-r--r-- | arch/x86/events/intel/uncore_snbep.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c index 93b0f1f4d0d1..44c2f879f708 100644 --- a/arch/x86/events/intel/uncore_snbep.c +++ b/arch/x86/events/intel/uncore_snbep.c @@ -5111,6 +5111,8 @@ static int snr_uncore_mmio_map(struct intel_uncore_box *box, addr += box_ctl; + pci_dev_put(pdev); + box->io_addr = ioremap(addr, type->mmio_map_size); if (!box->io_addr) { pr_warn("perf uncore: Failed to ioremap for %s.\n", type->name); |