diff options
| author | Mark Rutland <mark.rutland@arm.com> | 2021-11-29 16:06:53 +0300 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2021-12-01 02:06:43 +0300 |
| commit | dca99fb643a2e9bc2e67a0f626b09d4f177f0f09 (patch) | |
| tree | 55747d41170b37c93cd762186cc7210e19c82ce8 /arch/x86/kernel/process.h | |
| parent | 7ad639840acf2800b5f387c495795f995a67a329 (diff) | |
| download | linux-dca99fb643a2e9bc2e67a0f626b09d4f177f0f09.tar.xz | |
x86: Snapshot thread flags
Some thread flags can be set remotely, and so even when IRQs are disabled,
the flags can change under our feet. Generally this is unlikely to cause a
problem in practice, but it is somewhat unsound, and KCSAN will
legitimately warn that there is a data race.
To avoid such issues, a snapshot of the flags has to be taken prior to
using them. Some places already use READ_ONCE() for that, others do not.
Convert them all to the new flag accessor helpers.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20211129130653.2037928-12-mark.rutland@arm.com
Diffstat (limited to 'arch/x86/kernel/process.h')
| -rw-r--r-- | arch/x86/kernel/process.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kernel/process.h b/arch/x86/kernel/process.h index 1d0797b2338a..76b547b83232 100644 --- a/arch/x86/kernel/process.h +++ b/arch/x86/kernel/process.h @@ -13,8 +13,8 @@ void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p); static inline void switch_to_extra(struct task_struct *prev, struct task_struct *next) { - unsigned long next_tif = task_thread_info(next)->flags; - unsigned long prev_tif = task_thread_info(prev)->flags; + unsigned long next_tif = read_task_thread_flags(next); + unsigned long prev_tif = read_task_thread_flags(prev); if (IS_ENABLED(CONFIG_SMP)) { /* |