summaryrefslogtreecommitdiff
path: root/drivers/amba/bus.c
diff options
context:
space:
mode:
authorPeng Fan <peng.fan@nxp.com>2023-08-21 05:39:27 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-08-22 16:50:57 +0300
commite312cbdc11305568554a9e18a2ea5c2492c183f3 (patch)
tree4b1ac56d3d1c350de94619e6810c2ed168bd56a3 /drivers/amba/bus.c
parentdf8e2c3e16befe8c92ee6016059871d126015005 (diff)
downloadlinux-e312cbdc11305568554a9e18a2ea5c2492c183f3.tar.xz
amba: bus: fix refcount leak
commit 5de1540b7bc4 ("drivers/amba: create devices from device tree") increases the refcount of of_node, but not releases it in amba_device_release, so there is refcount leak. By using of_node_put to avoid refcount leak. Fixes: 5de1540b7bc4 ("drivers/amba: create devices from device tree") Signed-off-by: Peng Fan <peng.fan@nxp.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230821023928.3324283-1-peng.fan@oss.nxp.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/amba/bus.c')
-rw-r--r--drivers/amba/bus.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index ce88af9eb562..09e72967b8ab 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -528,6 +528,7 @@ static void amba_device_release(struct device *dev)
{
struct amba_device *d = to_amba_device(dev);
+ of_node_put(d->dev.of_node);
if (d->res.parent)
release_resource(&d->res);
mutex_destroy(&d->periphid_lock);