summaryrefslogtreecommitdiff
path: root/drivers/clk/clk-scpi.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-10-21 23:41:40 +0300
committerStephen Boyd <sboyd@codeaurora.org>2015-12-01 03:29:15 +0300
commite80cf2e50bfabb14dd3667b2360a393dda3edc3f (patch)
tree5d1a9cb222ff36351dd85cfcc753f9978a078639 /drivers/clk/clk-scpi.c
parent279104e3ade92b38198fdaead9e84bd80057693a (diff)
downloadlinux-e80cf2e50bfabb14dd3667b2360a393dda3edc3f.tar.xz
clk: scpi: add missing of_node_put
for_each_available_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; @@ for_each_available_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Acked-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Diffstat (limited to 'drivers/clk/clk-scpi.c')
-rw-r--r--drivers/clk/clk-scpi.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c
index 0b501a9fef92..cd0f2726f5e0 100644
--- a/drivers/clk/clk-scpi.c
+++ b/drivers/clk/clk-scpi.c
@@ -292,6 +292,7 @@ static int scpi_clocks_probe(struct platform_device *pdev)
ret = scpi_clk_add(dev, child, match);
if (ret) {
scpi_clocks_remove(pdev);
+ of_node_put(child);
return ret;
}
}