summaryrefslogtreecommitdiff
path: root/drivers/dma/img-mdc-dma.c
diff options
context:
space:
mode:
authorLars-Peter Clausen <lars@metafoo.de>2015-11-21 14:09:48 +0300
committerVinod Koul <vinod.koul@intel.com>2015-12-05 13:26:42 +0300
commit9ff68186eaac415bfc0b84d627b7ecec24b0c52d (patch)
treeb9433e39c949dd19f20e3fdf978b6cdd6c1ad336 /drivers/dma/img-mdc-dma.c
parent1f281792f649fc40054fc9146d8aa6b8b3c2aaff (diff)
downloadlinux-9ff68186eaac415bfc0b84d627b7ecec24b0c52d.tar.xz
dmaengine: img-mdc: Remove unnecessary synchronize_irq() before devm_free_irq()
Calling synchronize_irq() right before devm_free_irq() is quite useless. On one hand the IRQ can easily fire again before devm_free_irq() is entered, on the other hand devm_free_irq() itself calls synchronize_irq() internally (in a race condition free way), before any state associated with the IRQ is freed. Patch was generated using the following semantic patch: // <smpl> @@ expression irq, dev; @@ -synchronize_irq(irq); devm_free_irq(dev, irq, ...); // </smpl> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/img-mdc-dma.c')
-rw-r--r--drivers/dma/img-mdc-dma.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/dma/img-mdc-dma.c b/drivers/dma/img-mdc-dma.c
index 9ca56830cc63..42ae58d1e303 100644
--- a/drivers/dma/img-mdc-dma.c
+++ b/drivers/dma/img-mdc-dma.c
@@ -979,7 +979,6 @@ static int mdc_dma_remove(struct platform_device *pdev)
vc.chan.device_node) {
list_del(&mchan->vc.chan.device_node);
- synchronize_irq(mchan->irq);
devm_free_irq(&pdev->dev, mchan->irq, mchan);
tasklet_kill(&mchan->vc.task);