summaryrefslogtreecommitdiff
path: root/drivers/extcon/extcon-max14577.c
diff options
context:
space:
mode:
authorAndrzej Hajda <a.hajda@samsung.com>2015-12-14 13:06:02 +0300
committerChanwoo Choi <cw00.choi@samsung.com>2015-12-15 04:02:03 +0300
commitc2957563ad0965c8bfb393dcd22ddb683dd1ff1c (patch)
tree032f2a0ef33d60f9787e02e53d11d3871c519fe9 /drivers/extcon/extcon-max14577.c
parent36e2693b68562d4b984b841c041ffa76370e9b7f (diff)
downloadlinux-c2957563ad0965c8bfb393dcd22ddb683dd1ff1c.tar.xz
extcon: max14577: fix handling return value of regmap_irq_get_virq
The function can return negative values, so its result should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon/extcon-max14577.c')
-rw-r--r--drivers/extcon/extcon-max14577.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
index 601dbd996487..b30ab97ce75f 100644
--- a/drivers/extcon/extcon-max14577.c
+++ b/drivers/extcon/extcon-max14577.c
@@ -692,7 +692,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
/* Support irq domain for max14577 MUIC device */
for (i = 0; i < info->muic_irqs_num; i++) {
struct max14577_muic_irq *muic_irq = &info->muic_irqs[i];
- unsigned int virq = 0;
+ int virq = 0;
virq = regmap_irq_get_virq(max14577->irq_data, muic_irq->irq);
if (virq <= 0)