summaryrefslogtreecommitdiff
path: root/drivers/firmware/broadcom
diff options
context:
space:
mode:
authorVikas Gupta <vikas.gupta@broadcom.com>2020-01-06 09:24:02 +0300
committerDavid S. Miller <davem@davemloft.net>2020-01-07 00:51:37 +0300
commit4012a6f2fa562b4b2884ea96db263caa4c6057a8 (patch)
tree527bcfe958a571f8b2654778871ea963efefea8f /drivers/firmware/broadcom
parentd8dc2c9676e614ef62f54a155b50076888c8a29a (diff)
downloadlinux-4012a6f2fa562b4b2884ea96db263caa4c6057a8.tar.xz
firmware: tee_bnxt: Fix multiple call to tee_client_close_context
Fix calling multiple tee_client_close_context in case of shm allocation fails. Fixes: 246880958ac9 (“firmware: broadcom: add OP-TEE based BNXT f/w manager”) Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/firmware/broadcom')
-rw-r--r--drivers/firmware/broadcom/tee_bnxt_fw.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index 5b7ef89eb701..ed10da5313e8 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -215,7 +215,6 @@ static int tee_bnxt_fw_probe(struct device *dev)
fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ,
TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
if (IS_ERR(fw_shm_pool)) {
- tee_client_close_context(pvt_data.ctx);
dev_err(pvt_data.dev, "tee_shm_alloc failed\n");
err = PTR_ERR(fw_shm_pool);
goto out_sess;