summaryrefslogtreecommitdiff
path: root/drivers/firmware/efi/capsule.c
diff options
context:
space:
mode:
authorJeremy Compostella <jeremy.compostella@intel.com>2016-05-07 00:39:28 +0300
committerIngo Molnar <mingo@kernel.org>2016-05-07 08:06:13 +0300
commit2e121d711a51f91e792595a05cf9ef6963cb8464 (patch)
tree510005d33d6a005fc980a78134a116e55c11c23c /drivers/firmware/efi/capsule.c
parent62075e581802ea1842d5d3c490a7e46330bdb9e1 (diff)
downloadlinux-2e121d711a51f91e792595a05cf9ef6963cb8464.tar.xz
efibc: Fix excessive stack footprint warning
GCC complains about a newly added file for the EFI Bootloader Control: drivers/firmware/efi/efibc.c: In function 'efibc_set_variable': drivers/firmware/efi/efibc.c:53:1: error: the frame size of 2272 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] The problem is the declaration of a local variable of type struct efivar_entry, which is by itself larger than the warning limit of 1024 bytes. Use dynamic memory allocation instead of stack memory for the entry object. This patch also fixes a potential buffer overflow. Reported-by: Ingo Molnar <mingo@kernel.org> Reported-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> [ Updated changelog to include GCC error ] Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/1462570771-13324-3-git-send-email-matt@codeblueprint.co.uk Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/firmware/efi/capsule.c')
0 files changed, 0 insertions, 0 deletions