diff options
| author | Dave Airlie <airlied@redhat.com> | 2017-09-29 08:44:54 +0300 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2017-09-29 20:02:21 +0300 |
| commit | b08c3ca4e90d03b3a120f4e60dba4b2b5e087433 (patch) | |
| tree | a9ccc554e707c30a2e6ccaa6073d0d1b761bca89 /drivers/gpu/drm/amd/display/dc/i2caux/dcn10 | |
| parent | 4179cd81376112d627216580b09b803eb25e1635 (diff) | |
| download | linux-b08c3ca4e90d03b3a120f4e60dba4b2b5e087433.tar.xz | |
amdgpu/dc: remove pointless returns in the i2caux constructor paths. (v2)
There was lots of return true, and error checking that was never used
in these paths.
Just remove it all.
v2: I missed one return true.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/i2caux/dcn10')
| -rw-r--r-- | drivers/gpu/drm/amd/display/dc/i2caux/dcn10/i2caux_dcn10.c | 21 |
1 files changed, 7 insertions, 14 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/i2caux/dcn10/i2caux_dcn10.c b/drivers/gpu/drm/amd/display/dc/i2caux/dcn10/i2caux_dcn10.c index f8659f1c5f9d..13b807d8aff8 100644 --- a/drivers/gpu/drm/amd/display/dc/i2caux/dcn10/i2caux_dcn10.c +++ b/drivers/gpu/drm/amd/display/dc/i2caux/dcn10/i2caux_dcn10.c @@ -108,18 +108,11 @@ struct i2caux *dal_i2caux_dcn10_create( return NULL; } - if (dal_i2caux_dce110_construct( - i2caux_dce110, - ctx, - dcn10_aux_regs, - dcn10_hw_engine_regs, - &i2c_shift, - &i2c_mask)) - return &i2caux_dce110->base; - - ASSERT_CRITICAL(false); - - kfree(i2caux_dce110); - - return NULL; + dal_i2caux_dce110_construct(i2caux_dce110, + ctx, + dcn10_aux_regs, + dcn10_hw_engine_regs, + &i2c_shift, + &i2c_mask); + return &i2caux_dce110->base; } |